Now I'm confused. If I understand the code, what I want is for the
"io_32bit" setting to have its RW field set to SETTING_READ, such
that drive->no_io_32bit can NOT be changed. Additionally, I want it
set to 1 if hwif->no_io_32bit is 1.
Yes.
Are you saying that at the end of probe_hwif() I should iterate over
the drives for that hwif and set drive->no_io_32bit to 1 if hwif-
no_io_32bit is 1? If so, can I do this in the last loop that
already exists that iterates over the drives?
Well, no - this loop is for tuning and is already over-complicated.
Will I not also want to test hwif->no_io_32bit in idedisk_setup() to
ensure that it can only set driver->no_io_32bit to 0 if hwif-
no_io32bit is 0?
No, you want to move this code to ide-probe.c because of the
reason given in my last mail: setting drive->no_io_32bit in ide-disk
is too late w.r.t. ide_add_generic_settings():
init_gendisk()->hwif_init()->ide_add_generic_settings()
so drive->no_io_32bit flag needs to be set earlier
(probe_hwif() is OK).
Will drive->id->dword_io be valid by the end of probe_hwif()?
And yes, this IDE stuff is complicated... :)
That it is ;)
- kumar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
