On Tue, Jan 31, 2006 at 06:09:27PM -0800, Andrew Morton wrote: > Harald Welte <[email protected]> wrote: > > > > Please apply this fix to the cm4000/4040 drivers, thanks! > > > > [CM4000,CM4040] Add device class bits to enable udev device creation > > > > Using this patch, Omnikey CardMan 4000 and 4040 devices automatically > > get their device nodes created by udev. > > Dominik has made quite widespread changes to these drivers - enough that > I'm not confident to fix the rejects, make it compile and hope that it > still works. sorry for that. I honestly don't have the time to track two trees, and I do all my development work against Linus' main tree, therefore my patches are against that tree, too. > So can you please sort things out with Dominik? I guess a tested patch > against -mm4 would be ideal. The question is: Why wouldn't my patch directly go mainline but rather via -mm? It is a very special-purpose device, the number of users are small, it clearly fixes the bug that no device nodes are created, and the fix came from the original maintainer. > I note that these drivers forget to check for pcmcia_register_driver() > failure. That's a fairly good way of getting an oops in rmmod. Thanks, I'll cook up a fix. -- - Harald Welte <[email protected]> http://gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
Attachment:
pgp5cMMbCLL7W.pgp
Description: PGP signature
- Follow-Ups:
- References:
- Prev by Date: RE: [patch 0/2] fix perf. bug in wake-up load balancing for aim7 and db workload
- Next by Date: Re: CD writing in future Linux (stirring up a hornets' nest)
- Previous by thread: Re: [PATCH] [CM4000,CM4040] Add device class bits to enable udev device creation
- Next by thread: Re: [PATCH] [CM4000,CM4040] Add device class bits to enable udev device creation
- Index(es):
 |