Andreas Gruenbacher wrote:
On Tuesday 14 February 2006 04:25, Peter Williams wrote:
The problem arises when pushing a patch that has errors in it (due to
changes in the previous patches in the series) and needs the -f flag to
force the push. What's happening is that the reverse of the errors is
being applied to the "pre patch" file in the .pc directory. Then when
you pop this patch it returns the file to a state with the reverse of
the errors applied to it.
Found and fixed. It's a missed rollback_patch on one of the two branches of
the code that checks if a patch can be reverse applied.
That was quick.
This case apparently
doesn't trigger as easily as it seems, or else we would have found it sooner.
Still quite bad.
Shall we wait until the translations are up-to-date again, or release 0.44
immediately?
I'm having trouble understanding how quilt could be dumb enough to do
this as surely the "pre patch" file in the .pc directory should be just
a copy of the file before the patch is applied.
Hey, it's just a bug.
:-)
This bug can completely hose a set of patches if the user doesn't notice
it very early and do something about it. The work around is to revert
to version 0.42 of quilt.
You should have sent your gquilt announcement to the quilt-dev list as well.
Thank you for summarizing the changes.
Sorry. They were mainly due to your change from "-p <patch>" to "-P
<patch>" for some commands. The other issue was a change to the return
value and error message when "quilt top" was used in a directory without
any quilt data. So no real changes to gquilt as seen by the user just
implementation changes.
BTW the --version function made it possible to make gquilt still work
with versions earlier than 0.43.
Thanks
Peter
--
Peter Williams [email protected]
"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
