On Sat, Feb 11, 2006 at 01:41:42PM -0800, Andrew Morton wrote: > Martin Hermanowski <[email protected]> wrote: > > > > Hi, > > > > 2.6.16-rc2-mm1 is running fine on my IBM notebook, but the hdaps module > > (acceleration sensor) does not work like I expected: > > > > ,----[ modprobe hdaps ] > > | Feb 11 21:24:26 nimrais kernel: hdaps: inverting axis readings. > > | Feb 11 21:24:26 nimrais kernel: hdaps: IBM ThinkPad T41p detected. > > | Feb 11 21:24:26 nimrais kernel: hdaps: driver successfully loaded. > > `---- > > > > AFAIK the module should create sysfs files in > > /sys/devices/platform/hdaps/, but I see only `bus', `power' and > > `uevent'. > > > > When unloading the hdaps module, I get a BUG: > > > > ,----[ rmmod hdaps ] > > | Feb 11 21:24:49 nimrais kernel: <c011d8b6> release_resource+0x76/0x80 <c0265bf4> platform_device_del+0x44/0x60 > > | Feb 11 21:24:49 nimrais kernel: <c0265c18> platform_device_unregister+0x8/0x10 <f9b9c8ed> hdaps_exit+0xd/0x25 [hdaps] > > | Feb 11 21:24:49 nimrais kernel: <f9b9c8e0> hdaps_exit+0x0/0x25 [hdaps] <c0132e05> sys_delete_module+0x145/0x1c0 > > | Feb 11 21:24:49 nimrais kernel: <c0149901> remove_vma+0x41/0x50 <c014ab57> do_munmap+0x1a7/0x200 > > | Feb 11 21:24:49 nimrais kernel: <c0102d91> syscall_call+0x7/0xb > > | Feb 11 21:24:49 nimrais kernel: hdaps: driver unloaded. > > `---- > > > > Do you need more information? > > > > Thanks, I'll drop hdaps-convert-to-the-new-platform-device-interface.patch, > which very likely to have caused this. > > You could try reverting that patch (wget > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc2/2.6.16-rc2-mm1/broken-out/hdaps-convert-to-the-new-platform-device-interface.patch > ; patch -p1 -R < hdaps-convert-to-the-new-platform-device-interface.patch) or please test next -mm, let us know? This fails: ,----[ patch -p1 -R < ../hdaps-convert-to-the-new-platform-device-interface.patch ] | patching file drivers/hwmon/hdaps.c | Hunk #1 succeeded at 37 (offset 1 line). | Hunk #2 succeeded at 63 (offset 1 line). | Hunk #3 succeeded at 285 with fuzz 2 (offset 1 line). | Hunk #4 FAILED at 321. | Hunk #5 FAILED at 340. | Hunk #6 succeeded at 474 (offset 1 line). | Hunk #7 succeeded at 512 (offset 1 line). | Hunk #8 succeeded at 533 (offset 1 line). | 2 out of 8 hunks FAILED -- saving rejects to file | drivers/hwmon/hdaps.c.rej `---- At hunk 4/5, the patch expects `down_trylock' and `up', while `mutex_trylock' and `mutex_unlock' are used in the actual file, I think. I will try next -mm anyway, because although the fsck-errors caused by ext3_getblocks are not harmful, they make me nervous ;-) -- Martin Hermanowski http://mh57.de/martin
Attachment:
signature.asc
Description: Digital signature
- Follow-Ups:
- Re: 2.6.16-rc2-mm1
- From: Andrew Morton <[email protected]>
- Re: 2.6.16-rc2-mm1
- References:
- 2.6.16-rc2-mm1
- From: Andrew Morton <[email protected]>
- Re: 2.6.16-rc2-mm1
- From: Martin Hermanowski <[email protected]>
- Re: 2.6.16-rc2-mm1
- From: Andrew Morton <[email protected]>
- 2.6.16-rc2-mm1
- Prev by Date: Re: Flames over -- Re: Which is simpler? (Was Re: [Suspend2-devel] Re: [ 00/10] [Suspend2] Modules support.)
- Next by Date: Re: [perfmon] perfmon2 code review: 32-bit ABI on 64-bit OS
- Previous by thread: Re: 2.6.16-rc2-mm1
- Next by thread: Re: 2.6.16-rc2-mm1
- Index(es):
 |