On Fri, 2006-02-10 at 17:45 -0500, Nicolas Pitre wrote:
>
> Actually, it will do almost the same as you originally did if you look
> at its definition. However, because a solution needs to be implemented
> to support multiple ports then using __raw_readl() at the driver level
> is more familiar to other kernel people.
>
Yea, I did notice that also. I just wanted to make sure I understood
what is going on so that I do not make the same mistake for the third
time.
> In fact, if there was only one SSP port, I'd have asked you to use
> SSPCR0, SSPDR, etc. directly. But the fact that the driver can handle
> multiple ports makes it rather messy (and the SSP*_P() macros in
> pxa-regs.h are an abomination IMHO).
>
I did not use the SSP*_P functions because of the mess. Actually at one
point the driver implemented register accesses in similar manner as
SSP*_P but David Brownell got me straightened out. Thus the original
question.
Stephen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
