Re: [PATCH] neofb: add more logic to determine sensibility of register readback

On Feb 10, 2006, at 06:53, Antonino A. Daplas wrote:

Christian Trefzer wrote:

+		par->PanelDispCntlRegRead = 0;
+		par->PanelDispCntlRegRead = 0;
+		par->PanelDispCntlRegRead = 0;
+		par->PanelDispCntlRegRead = 0;
+		par->PanelDispCntlRegRead = 1;

You can save a few lines by

par->PanelDispCntlRegRead = (blank_mode) ? 0 : 1;

How about the really simple so-obvious-its-impossible-to-misread solution?

par->PanelDispCntlRegRead = !blank_mode;

Personally I tend to get ?: constructs confused a _lot_, especially mistaking the really short ones like x?0:1 and x?1:0. Those two are usually better represented as !x or !!x, respectively.

Cheers,
Kyle Moffett

--

I lost interest in "blade servers" when I found they didn't throw knives at people who weren't supposed to be in your machine room.

  -- Anthony de Boer


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] neofb: add more logic to determine sensibility of register readback
    • From: Christian Trefzer <[email protected]>

• References:
  • [PATCH] neofb: avoid resetting display config on unblank
    • From: Christian Trefzer <[email protected]>
  • [PATCH] neofb: add more logic to determine sensibility of register readback
    • From: Christian Trefzer <[email protected]>
  • Re: [PATCH] neofb: add more logic to determine sensibility of register readback
    • From: "Antonino A. Daplas" <[email protected]>

• Prev by Date: Re: msync() behaviour broken for MS_ASYNC, revert patch?
• Next by Date: Re: example of kernel thread
• Previous by thread: Re: [PATCH] neofb: add more logic to determine sensibility of register readback
• Next by thread: Re: [PATCH] neofb: add more logic to determine sensibility of register readback
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]