Re: libata janitor project

Jeff Garzik <jgarzik <at> pobox.com> writes:

> 
> 
> Long term, we should work to replace the assert() in libata with 
> standard kernel WARN_ON().
> 
> If someone wanted to handle that conversion, that would be useful.  Make 
> sure to pay attention, the sense of each test must be reversed.
> 
> 	Jeff
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo <at> vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Just so stupid little me understands this:
replace for example: 
  assert(sg != NULL)
with
  WARN_ON(sg == NULL)

right? 
...What about WARN_ON being defined bu HAVE_ARCH_BUG_ON and assert by ATA_DEBUG?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: libata janitor project
    • From: Jeff Garzik <[email protected]>

• References:
  • libata janitor project
    • From: Jeff Garzik <[email protected]>

• Prev by Date: [-mm patch] fs/xfs/linux-2.6/xfs_linux.h: #if CONFIG_SMP -> #ifdef CONFIG_SMP
• Next by Date: Re: [PATCH, RFC] [1/3] Generic in-kernel AC status
• Previous by thread: libata janitor project
• Next by thread: Re: libata janitor project
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]