Re: [PATCH] drivers/net/ns83820.c: add paramter to disable auto negotiation

[Andrew Morton <akpm@osdl.org>]

Dan Faerch <dan@scannet.dk> wrote:
>
> On Thu, 2006-02-09 at 20:17 -0800, Andrew Morton wrote: 
> > Steve Briggs <s-briggs@cecer.army.mil> wrote:
> > >
> > > This patch adds a module paramter, "auto_neg" which is
> > >  by default =1.  If it's set to zero, the auto negotiation
> > >  code in ns83820_init_one() is skipped and the interface is
> > >  set to 1000F.
> > 
> > Better to do this via `ethtool autoneg off'.
> 
> Actually I did somewhat the same patch about a year ago and got the same
> response:
> 
> "This functionality should likelz be done via ethtool..." - Benjamin
> LaHaise[1]
> 
> So i went back and spend about a week redoing the whole thing to enable
> ethtool support and reposted a patch[2], but didnt receive any response
> to this whatsoever. I even wrote the maintainer later on personally to
> ask if something was wrong with the patch, bad coding, anything, since
> there was no reply or reaction. I never received a reply.
> 
> So. There IS an ethtool patch and it works for me, though i dont know
> how well its made (there must be SOME reason i didnt get a response :)).

Well, sometimes one needs to persist.  Or copy me on the patch and I persist
for you ;)

> It supports autoneg, duplex and speed if i recall correctly.
> If you try it out, id love to hear comments (since this was/is the first
> time i messed around in kernel stuff).
> 

The patch you have here has all its tabs replaced with spaces and apart
from that doesn't apply to the current development tree.  And it seems
to have some very random whitespace usage as well, although I usually
fix those things up if the patch isn't enormous.

Could you fix all this up, generate a nice changelog, add a Signed-off-by:
as per section 11 of Documentation/SubmittingPatches and resend?

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/