Re: [PATCH] mm: Implement Swap Prefetching v23

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton wrote:
Nick Piggin <[email protected]> wrote:

Andrew Morton wrote:

Con Kolivas <[email protected]> wrote:


Ok I see. We don't have a way to add to the tail of that list though?


del_page_from_lru() + (new) add_page_to_inactive_list_tail().



Is that a worthwhile addition to this (ever growing) project? That would definitely have an impact on the other code if not all done within swap_prefetch.c.. which would also be quite a large open coded something.


Do both of the above in a new function in swap.c.


That'll require the caller to do lru locking.

I'd add an lru_cache_add_tail, use it instead of the current lru_cache_add
that Con's got now, and just implement it in a simple manner, without
pagevecs.


umm, that's what I said ;)


You said del_page_from_lru(), which doesn't belong in a function
called lru_cache_add_tail.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux