Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return

>> I created this little patch while reading through drivers/block/ub.c. It fixes
>> some indentation/whitespace as well as some empty commenting, an hardcoded
>> module name and an unneeded return.
>
>I strongly disagree.
>
>But the rest is quite bad, the worst being indenting the switch statement.
>
switch(a) {
case A:
    dosomething;
    break;
}

Now what if

switch(a) {
case A: {
    int tmp;
    do_something;
    break;
}
}


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return
    • From: Pete Zaitcev <[email protected]>

• References:
  • Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return
    • From: Pete Zaitcev <[email protected]>

• Prev by Date: Re: [PATCH] percpu data: only iterate over possible CPUs
• Next by Date: Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return
• Previous by thread: Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return
• Next by thread: Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]