Re: [PATCH, RFC] [1/3] Generic in-kernel AC status

Hi!

On Wed, Feb 08, 2006 at 01:04:22PM +0000, Matthew Garrett wrote:
> diff --git a/include/linux/pm.h b/include/linux/pm.h
...
> +void pm_set_ac_status(int (*ac_status_function)(void))
> +{
> +	down(&pm_sem);
> +	get_ac_status = ac_status_function;
> +	up(&pm_sem);
> +}

Why do you need a semaphore/mutex, when you only do one assignment,
which is atomic by itself?

BYtE
Philipp
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ [email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH, RFC] [1/3] Generic in-kernel AC status
    • From: Pavel Machek <[email protected]>

• References:
  • [PATCH, RFC] [1/3] Generic in-kernel AC status
    • From: Matthew Garrett <[email protected]>
  • Re: [PATCH, RFC] [1/3] Generic in-kernel AC status
    • From: Matthew Garrett <[email protected]>

• Prev by Date: Re: KERNEL: assertion (!sk->sk_forward_alloc) failed
• Next by Date: RE: [2.6 patch] let IA64_GENERIC select more stuff
• Previous by thread: Re: [linux-pm] Re: [PATCH, RFC] [1/3] Generic in-kernel AC status
• Next by thread: Re: [PATCH, RFC] [1/3] Generic in-kernel AC status
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]