With the bug fixes from killing session == 0 and pgrp == 0 we
have essentially made pid == 1 a session leader. However reading
through the code I can see nothing, that sets the session->leader
flag. In fact we actively clear it in all cases during clone.
And setsid will fail to set it because the session == 1 and
process group == 1 already exist.
So this patch forces the session leader flag and for good measure
the pgrp, session and tty of init as well.
Signed-off-by: Eric W. Biederman <[email protected]>
---
kernel/fork.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
6bc9fa2aca38bf739e20ae6192a068310ff9739a
diff --git a/kernel/fork.c b/kernel/fork.c
index a08e5cf..ff10b11 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1179,9 +1179,16 @@ static task_t *copy_process(unsigned lon
attach_pid(p, PIDTYPE_PID, p->pid);
attach_pid(p, PIDTYPE_TGID, p->tgid);
if (thread_group_leader(p)) {
- p->signal->tty = current->signal->tty;
- p->signal->pgrp = process_group(current);
- p->signal->session = current->signal->session;
+ if (unlikely(p->pid == 1)) {
+ p->signal->tty = NULL;
+ p->signal->leader = 1;
+ p->signal->pgrp = 1;
+ p->signal->session = 1;
+ } else {
+ p->signal->tty = current->signal->tty;
+ p->signal->pgrp = process_group(current);
+ p->signal->session = current->signal->session;
+ }
attach_pid(p, PIDTYPE_PGID, process_group(p));
attach_pid(p, PIDTYPE_SID, p->signal->session);
__get_cpu_var(process_counts)++;
--
1.1.5.g3480
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
