Re: [patch 6/6] [NETFILTER]: Fix another crash in ip_nat_pptp (CVE-2006-0037)

On Fri, Jan 27, 2006 at 06:18:35PM -0800, Greg KH wrote:

>  	DEBUGP("altering call id from 0x%04x to 0x%04x\n",
> -		ntohs(*cid), ntohs(new_callid));
> +		ntohs(*(u_int16_t *)pptpReq + cid_off), ntohs(new_callid));

Note that this fix introduces another bug in the above use DEBUGP
statement, as there is (u_int16_t *) ptr arithmetic used, whereas
cid_off is a byte offset.

A fix for that was send a few weeks ago on netfilter-devel.

/holger

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [stable] Re: [patch 6/6] [NETFILTER]: Fix another crash in ip_nat_pptp (CVE-2006-0037)
  - From: Greg KH <[email protected]>

References:
- [patch 6/6] [NETFILTER]: Fix another crash in ip_nat_pptp (CVE-2006-0037)
  - From: Greg KH <[email protected]>

Prev by Date: Re: [PATCH] add execute_in_process_context() API
Next by Date: [PATCH, RFC] [1/3] Generic in-kernel AC status
Previous by thread: [patch 6/6] [NETFILTER]: Fix another crash in ip_nat_pptp (CVE-2006-0037)
Next by thread: Re: [stable] Re: [patch 6/6] [NETFILTER]: Fix another crash in ip_nat_pptp (CVE-2006-0037)
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]