Re: [patch 15/44] generic ext2_{set,clear,test,find_first_zero,find_next_zero}_bit()

On Wed, Feb 01, 2006 at 12:27:38PM +0100, Roman Zippel wrote:

> For the inline version I would prefer this version:
> 
> {
> 	const unsigned char *tmp = (const unsigned char *)addr;
> 	return (tmp[nr >> 3] & (unsigned char)(1 << (nr & 7))) != 0;
> }
> 
> Although this would be a good alternative as well:
> 
> {
> 	return (addr[nr >> 5] & (1 << ((nr ^ 24) & 31))) != 0;
> }

Thanks, maybe I could use BITOP_LE_SWIZZLE similar to other *_le_bit().

#define BITOP_LE_SWIZZLE       ((BITS_PER_LONG-1) & ~0x7)
 :
#define generic_test_le_bit(nr, addr) test_bit((nr) ^ BITOP_LE_SWIZZLE, (addr))
 :
#endif /* __BIG_ENDIAN */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 00/44] generic bitops
    • From: Akinobu Mita <[email protected]>
  • [patch 15/44] generic ext2_{set,clear,test,find_first_zero,find_next_zero}_bit()
    • From: Akinobu Mita <[email protected]>
  • Re: [patch 15/44] generic ext2_{set,clear,test,find_first_zero,find_next_zero}_bit()
    • From: Roman Zippel <[email protected]>

• Prev by Date: Re: [PATCH] unify pfn_to_page take 2 [9/25] frv funcs
• Next by Date: Re: preempt-rt, NUMA and strange latency traces
• Previous by thread: Re: [patch 15/44] generic ext2_{set,clear,test,find_first_zero,find_next_zero}_bit()
• Next by thread: [patch 05/44] generic {,test_and_}{set,clear,change}_bit()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]