On Mon, 6 Feb 2006, Ravikiran G Thirumalai wrote: > IMHO, if you keep something around which is not needed, it might later get > abused/misused. And what would you add in as comments for the > cachep->spinlock? > > Instead, bold comments on cachep structure stating what all members are > protected by which lock/mutex should be sufficient no? Yeah, I guess we can put the spinlock back if we ever need it. Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [patch 0/3] NUMA slab locking fixes
- From: Ravikiran G Thirumalai <kiran@scalex86.org>
- Re: [patch 0/3] NUMA slab locking fixes
- From: Andrew Morton <akpm@osdl.org>
- Re: [patch 0/3] NUMA slab locking fixes
- From: Christoph Lameter <clameter@engr.sgi.com>
- Re: [patch 0/3] NUMA slab locking fixes
- From: Ravikiran G Thirumalai <kiran@scalex86.org>
- [patch 2/3] NUMA slab locking fixes - move irq disabling from cahep->spinlock to l3 lock
- From: Ravikiran G Thirumalai <kiran@scalex86.org>
- Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from cahep->spinlock to l3 lock
- From: Andrew Morton <akpm@osdl.org>
- Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from cahep->spinlock to l3 lock
- From: Ravikiran G Thirumalai <kiran@scalex86.org>
- Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from cahep->spinlock to l3 lock
- From: Andrew Morton <akpm@osdl.org>
- Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from cahep->spinlock to l3 lock
- From: Christoph Lameter <clameter@engr.sgi.com>
- Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from cahep->spinlock to l3 lock
- From: Pekka J Enberg <penberg@cs.Helsinki.FI>
- Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from cahep->spinlock to l3 lock
- From: Ravikiran G Thirumalai <kiran@scalex86.org>
- [patch 0/3] NUMA slab locking fixes
- Prev by Date: Re: non-fakeraid controllers
- Next by Date: Re: [Patch] 2.4.32 - Neighbour Cache (ARP) State machine bug Fixed
- Previous by thread: Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from cahep->spinlock to l3 lock
- Next by thread: [patch 3/3] NUMA slab locking fixes -- fix cpu down and up locking
- Index(es):
![]() |