Re: [PATCH, RFC] Driver for reading HP laptop LCD brightness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2006-02-05 at 13:55 +0000, Matthew Garrett wrote:
> +	if (enable==0) {
> +		return snprintf(buf, PAGE_SIZE, "NA\n");
> +	}
> +
> +	disable_irq(8);
> +
> +	outb(0x97, 0x72);
> +	value = inb(0x73);
> +	
> +	enable_irq(8);
> +

disable_irq() and enable_irq() are really really evil. Are you sure you
need these? To me on first sight it looks like a bug (think of shared
interrupts for example), can you explain what you are trying to achieve
with these?

Greetings,
     Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux