Re: [PATCH] liyitec: Liyitec PS/2 touchscreen driver

[Shaun Jackman <sjackman@gmail.com>]

On 2/4/06, Vojtech Pavlik <vojtech@suse.cz> wrote:
> On Fri, Feb 03, 2006 at 05:39:30PM -0700, Shaun Jackman wrote:
> > So, finally, assuming there is no way to detect the touch panel's
> > presence, should the driver still be rolled into psmouse? If so, how
> > should the user specify she wishes to use the liyitec driver, and
> > which serio (PS/2) port the liyitec touch screen is on?
> >
> > My current patch implements the Liyitec driver as a serio driver that
> > grabs every available PS/2 port. Quite unfriendly, but works in the
> > typical case where the keyboard driver grabs the first port, and the
> > Liyitec driver grabs the psaux port.
>
> I hope the driver at least checks that the port is untranslated
> (SERIO_I8042, not SERIO_I8042_XL), and that the device behaves as a
> mouse.

I'm unable to find any reference to SERIO_I8042_XL.
$ cat .git/HEAD
d39569232e883a1475b39576b96cfb400c33e816
$ grep -r I8042_XL .
$

The driver does not check that the device behaves as a normal mouse.
It would be relatively straight forward to implement this feature, but
since psmouse already does this, this behaviour would be a major
benefit to moving the Liyitec driver into psmouse.

> Btw, I assume the packet format is also indistinguishable from a
> standard PS/2 mouse?

The Liyitec packet is always a legal PS/2 packet. However, the
overflow bits are used as the tenth bits of precision of the absolute
X and Y coordinates, and so are set far more often than on a normal
PS/2 mouse, assuming the user touches the bottom right corner of the
screen.

> If it were integrated into psmouse, it probably need to be enabled by a
> module parameter.

Okay. I'll do that then. How is the module parameter specified for a
driver that's compiled into the kernel?

Cheers,
Shaun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/