Re: [PATCH] EDAC printk() cleanup

[doug thompson <dthompson@linuxnetworx.com>]

On Wed, 2006-02-01 at 19:16 -0800, Dave Peterson wrote:
> On Monday 30 January 2006 19:22, Eric W. Biederman wrote:
> > One piece missing from this conversation is the issue that we need errors
> > in a uniform format.  That is why edac_mc has helper functions.
> >
> > However there will always be errors that don't fit any particular model.
> > Could we add a edac_printk(dev, );  That is similar to dev_printk but
> > prints out an EDAC header and the device on which the error was found?
> > Letting the rest of the string be user specified.
> >
> > For actual control that interface may be to blunt, but at least for people
> > looking in the logs it allows all of the errors to be detected and
> > harvested.
> 
> Ok, the patch below (which applies to the 2.6.16-rc1-git4 kernel) is
> an initial attempt at implementing this sort of thing.  Here is some
> sample output (produced by loading the edac_mc and e7xxx_edac
> moules):
> 
>     EDAC MC: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c version edac_mc  Ver: 2.0.0 Feb  1 2006
>     EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_sysfs_memctrl_setup()
>     EDAC DEBUG: Registered '.../edac/mc' kobject
>     EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_sysfs_pci_setup()
>     EDAC DEBUG: Registered '.../edac/pci' kobject
>     EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/e7xxx_edac.c: e7xxx_init_one()
>     EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/e7xxx_edac.c: e7xxx_probe1(): mci
>     EDAC e7xxx: tolm = 40000, remapbase = ffc000, remaplimit = 0
>     EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_mc_add_mc()
>     EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_create_sysfs_mci_device() idx=0
>     EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_create_csrow_object()
>     EDAC DEBUG: Registered CSROW0
>     EDAC MC0: Giving out device to e7xxx_edac E7500: PCI 0000:00:00.0
> 


Yes, yes, yes

that is exactly what I had in mind. The old stuff bothered me something
bad, but I couldn't put my finger on exactly how to fix it yet - didn't
have the time.

It gives subsystem info (EDAC), modules therein, a bit of context then
event descriptions.

thanks dave and eric and good work

doug t


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/