Re: [ 00/10] [Suspend2] Modules support.

[Nigel Cunningham <nigel@suspend2.net>]

Hi.

On Thursday 02 February 2006 20:47, Pavel Machek wrote:
> Hi!
>
> > > > This set of patches represents the core of Suspend2's module support.
> > > >
> > > > Suspend2 uses a strong internal API to separate the method of
> > > > determining the content of the image from the method by which it is
> > > > saved. The code for determining the content is part of the core of
> > > > Suspend2, and transformations (compression and/or encryption) and
> > > > storage of the pages are handled by 'modules'.
> > >
> > > swsusp already has a very strong API to separate image writing from
> > > image creation (in -mm patch, anyway). It is also very nice, just
> > > read() from /dev/snapshot. Please use it.
> >
> > You know that's not an option.
>
> No, I don't... please explain. Switching to this interface is going to
> be easier than pushing suspend2 into kernel. Granted, end result may
> not be suspend2, it may be something like suspend3, but it will be
> better result than u-swsusp or suspend2 is today...

It's not an option because I'm not trying not to step all over your codebase, 
because I'm not moving suspend2 to userspace and because it doesn't make 
sense to add another layer of abstraction by sticking /dev/snapshot in the 
middle of kernel space code. There may be more reasons, but I haven't looked 
at the /dev/snapshot code at all.

Regards,

Nigel

-- 
See our web page for Howtos, FAQs, the Wiki and mailing list info.
http://www.suspend2.net                IRC: #suspend2 on Freenode

Attachment: pgpiQp0XO2zRm.pgp
Description: PGP signature