Re: Badness in local_bh_enable by [PATCH] fix uidhash_lock <-> RCU deadlock

[Linus Torvalds <torvalds@osdl.org>]

On Wed, 1 Feb 2006, Alexey Dobriyan wrote:
>
> Flooding boot logs with
> 
> Badness in local_bh_enable at kernel/softirq.c:140

Ok, looks bad. It's through

    __dequeue_signal():
	collect_signal():
	    __sigqueue_free():
		free_uid()

where we hold the sigqueue lock. We do _not_ want to do BH processing 
there with the lock held and interrupts disabled, so the warning is 
correct, and that uidhash_lock patch potentially causes more problems than 
it fixes.

Perhaps the easiest solution is to just make them irq-safe instead 
of bh-safe? An alternative might be to make __sigqueue_free() do its work 
through RCU callbacks too, but that seems wrong.

Comments? Ingo?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/