Re: noisy edac

[Gunther Mayer <gunther.mayer@gmx.net>]

Dave Peterson wrote:

> On Monday 30 January 2006 13:04, doug thompson wrote:
>  
>
> > Something like an ERROR report verbose level?  0 to 7 like?
> >
> > 0 being quiet, 7 being very verbose? or the reverse.
> >
> > /sys/drivers/system/edac/mc/error_report_verbosity   ????
> >
> > This tackles the immediate issue, but there is a systemic issue we have
> > to face sometime.
> >
> > One problem that this e752x_edac module exhibits, which is manifest on
> > all of the drivers to one degree, is the output of driver specific error
> > messages directly, since there is not an abstracted error interface
> > (yet) in the EDAC core.  The messages are or can be very specific to the
> > MC being driven.  In time, we can (should) add a better MC error
> > interface to the core and then map errors from specific MC errors to the
> > new CORE error interface. Similiar to how SCSI and SATA have higher
> > level abstract errors which the transport drivers map errors to.
> >
> > This e752x_edac module just plainly outputs to printk() with
> > KERN_WARNING w/o any other output control.
> >
> > Looks like the old "how do we report errors" pattern, with its first
> > implementation now looking old.
> >    
>
> For each individual type of error that is specific to a particular
> low-level chipset driver (e752x, amd76x, etc.) there could be an entry
> in the appropriate part of the sysfs hierarchy under the given chipset
> driver.  This entry could have several settings that the user may choose
> from such as { ignore, syslog, panic }.  For the implementation, there
> could be a generic piece of code in the core EDAC module that a chipset
> driver calls into.  The generic code would do the dirty work of creating
> the sysfs entries (and destroying them when the chipset module is
> unloading).  How does this sound?
> -
>  
Over-Engineered.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/