Re: [PATCH] exec: Cleanup exec from a non thread group leader.

Oleg Nesterov <[email protected]> writes:

> Oleg Nesterov wrote:
>> 
>> Eric W. Biederman wrote:
>> >
>> > -     list_add_tail(&thread->tasks, &init_task.tasks);
>> 
>> The last deletion is wrong, I beleive.
>
> Just to clarify, it looks like we can kill this line because
> de_thread() also does list_add_tail(current, &init_task.tasks).
>
> But please note that it (and probably __ptrace_link() above)
> does list_del(current->task) first, and current->task may have
> very stale values after old leader called dup_task_struct().
> SET_LINKS() in copy_process() does nothing with ->tasks in a
> CLONE_THREAD case.

Good point in that instance we need to remove the list_del
as well.

As for the other stale data that bears looking at.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] exec: Cleanup exec from a non thread group leader.
    • From: Oleg Nesterov <[email protected]>

• References:
  • Re: [PATCH] exec: Cleanup exec from a non thread group leader.
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] exec: Cleanup exec from a non thread group leader.
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: Unique /proc/<pid>/fd/ inode numbers?
• Next by Date: Re: 2.6.15-rt16
• Previous by thread: Re: [PATCH] exec: Cleanup exec from a non thread group leader.
• Next by thread: Re: [PATCH] exec: Cleanup exec from a non thread group leader.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]