Re: [PATCH] libata queue updated

[Ingo Oeser <ioe-lkml@rameria.de>]

Hi Jeff,


On Saturday 28 January 2006 19:25, Jeff Garzik wrote:
> Testing and merge point in Tejun's flood of patches :)  The patch
> below is against current linux-2.6.git.

These "function(unsigned int *classes)" style functions in 
"libata-core.c" worry me somewhat.  Esp. that sometimes you have one class,
sometimes two.
This looks like a bug waiting to happen for me.

Could we somehow get a 

struct ata_classes {
	unsigned int master;
	unsigned int slave;
}

here (or similiar), before this is in used everywhere?

Usage would be function(struct ata_classes *classes) then.


Thanks & Regards

Ingo Oeser


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/