Re: [PATCH] rcu_process_callbacks: don't cli() while testing ->nxtlist

On Sat, Jan 28, 2006 at 10:02:01PM +0300, Oleg Nesterov wrote:
> __rcu_process_callbacks() disables interrupts to protect itself
> from call_rcu() which adds new entries to ->nxtlist.
> 
> However we can check "->nxtlist != NULL" with interrupts enabled,
> we can't get "false positives" because call_rcu() can only change
> this condition from 0 to 1.
> 
> Tested with rcutorture.ko.
> 
> Signed-off-by: Oleg Nesterov <[email protected]>

Looks good to me.

Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] rcu_process_callbacks: don't cli() while testing ->nxtlist
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: geocities.com URLs are now banned..
• Next by Date: Re: RCU latency regression in 2.6.16-rc1
• Previous by thread: [PATCH] rcu_process_callbacks: don't cli() while testing ->nxtlist
• Next by thread: [PATCH] [MTD] cmdlinepart: allow zero offset value
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]