Re: [patch 2/6] Create and Use common mempool allocators

Hi,

On Fri, 2006-01-27 at 16:19 -0800, Matthew Dobson wrote:
> -	cc->page_pool = mempool_create(MIN_POOL_PAGES, mempool_alloc_page,
> -				       mempool_free_page, NULL);
> +	cc->page_pool = mempool_create(MIN_POOL_PAGES, mempool_alloc_pages,
> +				       mempool_free_pages, 0);

You need to cast that zero to a void pointer to avoid compliation
warning (found in various other places as well). Would probably make
sense to implement helper functions so the casting doesn't spread all
over the place. Other than that, looks good to me.

			Pekka

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 2/6] Create and Use common mempool allocators
    • From: Matthew Dobson <[email protected]>

• Prev by Date: Do you want to save money on your medicine?
• Next by Date: Re: [patch 0/9] Critical Mempools
• Previous by thread: [patch 2/6] Create and Use common mempool allocators
• Next by thread: [patch 1/6] Create and Use common mempool allocators
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]