[PATCH 0/3] Fix overflow issues with sysctl values in centiseconds/seconds

Hi Andrew,

Here's a threesome of patches to fix up some issues with the following sysctl values:

/proc/sys/vm/laptop_mode
/proc/sys/vm/dirty_writeback_centisecs
/proc/sys/vm/dirty_expire_centisecs

The issues:
1. The values are not range checked when they are set. They all have
a range smaller than the full integer range.

2. Conversion from these centisecond/second values is done on-the-fly wherever they are used. This wastes some resources. 3. The conversions are done badly. Conversion from USER_HZ to HZ is done by doing "value * USER_HZ / HZ". One day expressed in centiseconds already causes an overflow at HZ = 250. This should use clock_t_to_jiffies() instead.

The approach:
1. Represent everything in jiffies internally.
2. Do the conversion and range checking in the sysctl interface.

Cheers,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 0/3] Fix overflow issues with sysctl values in centiseconds/seconds
    • From: Andrew Morton <[email protected]>

• Prev by Date: [PATCH 1/3] Represent dirty_*_centisecs as jiffies internally
• Next by Date: [PATCH 2/3] Represent laptop_mode as jiffies internally
• Previous by thread: [PATCH 1/3] Represent dirty_*_centisecs as jiffies internally
• Next by thread: Re: [PATCH 0/3] Fix overflow issues with sysctl values in centiseconds/seconds
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]