Re: [PATCH 1/2] [x86-64] align per-cpu section to configured cache bytes

[Zach Brown <zach.brown@oracle.com>]

Sam Ravnborg wrote:
> On Fri, Jan 27, 2006 at 02:02:42PM -0800, Zach Brown wrote:
> 
>>-  . = ALIGN(32);
>>+  . = ALIGN(CONFIG_X86_L1_CACHE_BYTES);
> 
> 
> Grepping other arch's than just x86 and x86_64 it looks like a common
> thing.
> Is this fix really only relevant for x86 + x86_64 or should it be done
> for all arch's?

I think it'd be needed if other archs had situations where C's
(load_module()'s, in particular) notion of the cacheline size differed
from vmlinux.lds.S's.  I didn't want to go screwing around with archs
that I couldn't immediately test :)

> If we do it for all archs we may as well create:
> #define PERCPU(aling) ...
> macro in asm-generic/vmlinux.lds.h

Sounds reasonable to me, should I leave that in your capable hands?

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/