Re: arch/i386/kernel/nmi.c: fix compiler warning

[Andrew Morton <akpm@osdl.org>]

Joe Perches <joe@perches.com> wrote:
>
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -90,12 +90,25 @@ void smp_prepare_boot_cpu(void);
>  #else /* !SMP */
>  
>  /*
> - *	These macros fold the SMP functionality into a single CPU system
> + *	These macros and inlines fold the SMP functionality
> + *	for single CPU systems
>   */
>  #define raw_smp_processor_id()			0
>  #define hard_smp_processor_id()			0
> -#define smp_call_function(func,info,retry,wait)	({ 0; })
> -#define on_each_cpu(func,info,retry,wait)	({ func(info); 0; })
> +
> +static inline int smp_call_function(void (*func) (void *info), void *info,
> +			      int retry, int wait)
> +{
> +	return 0;
> +}

I think we tried this before and it broke things.  Because there are
callback functions which are inside CONFIG_SMP.  With the macro, they don't
get referred to at all.  Wth the inline, the compiler needs to see their
definition and errors out.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/