On Fri, Jan 27 2006, James Bottomley wrote:
> On Fri, 2006-01-27 at 13:06 -0600, Mike Christie wrote:
> > It does not have anything to do with this in scsi_io_completion does it?
> >
> > if (blk_complete_barrier_rq(q, req, good_bytes >> 9))
> > return;
> >
> > For that case the scsi_cmnd does not get freed. Does it come back around
> > again and get released from a different path?
>
> It looks such a likely candidate, doesn't it. Unfortunately, Tejun Heo
> removed that code around 6 Jan (in [BLOCK] update SCSI to use new
> blk_ordered for barriers), so if it is that, then the latest kernels
> should now not be leaking.
Ah I thought so, seems my memory wasn't totally shot (don't have the
sources with me).
> However, all the avaliable evidence does seem to point to the write
> barrier enforcement. I'll take another look over those code paths.
The fact that it only happens with raid is very odd, though.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
