Re: [patch 2/4] net: Percpufy frequently used variables -- struct proto.memory_allocated

Ravikiran G Thirumalai a écrit :

Change struct proto->memory_allocated to a batching per-CPU counter (percpu_counter) from an atomic_t. A batching counter is better than a plain per-CPU counter as this field is read often.

Signed-off-by: Pravin B. Shelar <[email protected]>
Signed-off-by: Ravikiran Thirumalai <[email protected]>
Signed-off-by: Shai Fultheim <[email protected]>

Hello Ravikiran

I like this patch, but I'm not sure current percpu_counter fits the needs.

The percpu_counter_read() can return a value that is off by +-
FBC_BATCH*NR_CPUS, ie 2*(NR_CPUS^2) or 4*(NR_CPUS^2)

if NR_CPUS = 128, the 'error' from percpu_counter_read() is +- 32768

Is it acceptable ?

Thank you
Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 0/4] net: Percpufy frequently used variables on struct proto
    • From: Ravikiran G Thirumalai <[email protected]>
  • [patch 2/4] net: Percpufy frequently used variables -- struct proto.memory_allocated
    • From: Ravikiran G Thirumalai <[email protected]>

• Prev by Date: Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated
• Next by Date: Re: libata support for JMicron JMB360 ?
• Previous by thread: [patch 2/4] net: Percpufy frequently used variables -- struct proto.memory_allocated
• Next by thread: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]