Re: 2.6.16-rc1-mm3

[Eric Dumazet <dada1@cosmosbay.com>]

Andrew Morton a écrit :
> Andy Whitcroft <apw@shadowen.org> wrote:
> > Yes.  I think I have this one.  It appears that the patch below is the
> >  trigger for all our recent panic woe's.  The last of the testing should
> >  complete in the next few hours and I will be able to confirm that
> >  hypothesis; results so far are all good.
> >
> >  	reduce-size-of-percpudata-and-make-sure-per_cpuobject.patch
>
> That patch did have some missed conversions, which might well explain the
> crash.
>
> Thanks for narrowing it down - I'll keep that patch in next -mm (and will
> include the known fixups).  Could you please boot test that?  If we're
> still in trouble, I'll drop it.

The NULL choice was maybe wrong. We might need more than one page to fully 
catch all accesses. Something like 32KB.

In the meantime could you apply this one ?

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>


--- a/arch/i386/kernel/nmi.c	2006-01-27 07:51:04.000000000 +0100
+++ b/arch/i386/kernel/nmi.c	2006-01-27 07:52:14.000000000 +0100
@@ -148,7 +148,7 @@
 	if (nmi_watchdog == NMI_LOCAL_APIC)
 		smp_call_function(nmi_cpu_busy, (void *)&endflag, 0, 0);
 
-	for (cpu = 0; cpu < NR_CPUS; cpu++)
+	for_each_cpu(cpu)
 		prev_nmi_count[cpu] = per_cpu(irq_stat, cpu).__nmi_count;
 	local_irq_enable();
 	mdelay((10*1000)/nmi_hz); // wait 10 ticks