Adrian Bunk wrote:
On Mon, Jan 23, 2006 at 06:06:28PM -0500, Mike Krufky wrote:
Adrian Bunk wrote:
On Mon, Jan 23, 2006 at 06:24:44PM -0200, [email protected] wrote:
@@ -70,6 +71,16 @@ config VIDEO_CX88_DVB_MT352
This adds DVB-T support for cards based on the
Connexant 2388x chip and the MT352 demodulator.
+config VIDEO_CX88_VP3054
+ tristate "VP-3054 Secondary I2C Bus Support"
+ default m
This option should be a bool since "m" doesn't make much sense (it's
anyways interpreted the same as "y").
You have a point - it is a boolean choice yes/no, about whether or not
to compile support for this module, ... but it is in fact a module, and
when M is chosen, cx88-vp3054-i2c.ko will build as a module. When Y is
chosen, it will be built in-kernel.
I don't see this in your patches.
All your patches do is to define -DHAVE_VP3054_I2C=1 depending on
CONFIG_VIDEO_CX88_VP3054.
Oops! I made a mistake, but not the one you thought. The attached
patch fixes it.
Mauro, I just applied this to CVS, please apply on v4l-dvb.git
[PATCH] V4L/DVB: allow tristate build for cx88-vp3054-i2c
- allow tristate build for cx88-vp3054-i2c
Signed-off-by: Michael Krufky <[email protected]>
Index: linux/drivers/media/video/cx88/Makefile
===================================================================
RCS file: /cvs/video4linux/v4l-dvb/linux/drivers/media/video/cx88/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- linux/drivers/media/video/cx88/Makefile 21 Jan 2006 17:52:32 -0000 1.8
+++ linux/drivers/media/video/cx88/Makefile 24 Jan 2006 02:41:07 -0000
@@ -4,8 +4,9 @@ cx8800-objs := cx88-video.o cx88-vbi.o
cx8802-objs := cx88-mpeg.o
obj-$(CONFIG_VIDEO_CX88) += cx88xx.o cx8800.o cx8802.o cx88-blackbird.o
-obj-$(CONFIG_VIDEO_CX88_DVB) += cx88-dvb.o cx88-vp3054-i2c.o
+obj-$(CONFIG_VIDEO_CX88_DVB) += cx88-dvb.o
obj-$(CONFIG_VIDEO_CX88_ALSA) += cx88-alsa.o
+obj-$(CONFIG_VIDEO_CX88_VP3054) += cx88-vp3054-i2c.o
EXTRA_CFLAGS += -I$(src)/..
EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/dvb-core
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]