David H?rdeman <[email protected]> wrote:
>
> +static int dsa_setkey(void *ctx, const u8 *key, unsigned int keylen, u32 *flags)
> +{
> + struct dsa_ctx *dctx = ctx;
> +
> + if (keylen != sizeof(struct key_payload_dsa *)) {
> + printk("Invalid key size in dsa_setkey\n");
> + return -EINVAL;
> + }
> +
> + dctx->key = (struct key_payload_dsa *)key;
> + return 0;
> +}
This is bad. You're putting a pointer to an object with an unknown
lifetime into the tfm.
Is there anything wrong with allocating the memory for it and storing
the key in the tfm like everyone else?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
