On Fri, 20 Jan 2006 03:40:27 PST, Andrew Morton said: > Pekka Enberg <[email protected]> wrote: > > Hmm. This still leaves kstrdup() broken which is why I would prefer > > the following patch to be applied: > > kstrdup() doesn't get used much. > > > http://marc.theaimsgroup.com/?l=linux-kernel&m=113767657400334&w=2 > > That adds more complexity, IMO. A bit ifdeffy too. __do_kmalloc() should > be __always_inline, methinks? For what it's worth, I spent some time trying to get kstrdup() fixed as well, but gave up because: a) The leak I was chasing was using kzalloc() ;) b) I got stuck in a .h dependency loop - the prototype for kzalloc is in slab.h, and by that point in slab.h, we've seen a prototype for __kmalloc(). Unfortunately, kstrdup() comes out of string.h, and there's usages where string.h has been #included but we've not seen __kmalloc(). Unfortunately, just #include'ing what's needed didn't work, because of the way the code uses #ifndef _LINUX_FOO_H_ - when I started looking at having to #undef stuff to get a prototype of __kmalloc(), I gave up. ;)
Attachment:
pgp1Pghn5JtfR.pgp
Description: PGP signature
- References:
- 2.6.16-rc1-mm2
- From: Andrew Morton <[email protected]>
- Re: 2.6.16-rc1-mm2
- From: Pekka Enberg <[email protected]>
- Re: 2.6.16-rc1-mm2
- From: Andrew Morton <[email protected]>
- 2.6.16-rc1-mm2
- Prev by Date: Re: 2.4.x kernel uptime counter problem
- Next by Date: [PATCH 1/6] 2.6.16-rc1 perfmon2 patch for review
- Previous by thread: Re: 2.6.16-rc1-mm2
- Next by thread: [PATCH] zone_reclaim cpus_empty needs a real variable
- Index(es):
 |