Re: [linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume

On Wed, Jan 18, 2006 at 04:34:08PM +0100, Oliver Neukum wrote:
> Am Mittwoch, 18. Januar 2006 15:13 schrieb Johannes Berg:
> > On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote:
> > 
> > > This patch is wrong. usb_kill_urb() will sleep. You must not use it under
> > > a spinlock.
> > 
> > Whoops. Good catch. I'll have to analyse the logic with the lists being
> > used here (and probably add a temporary list). Will try to get a new
> > patch until tomorrow.
> > 
> > [side note: how about adding might_sleep() to usb_kill_urb? Then I'd at
> > least have noticed this right away]
> 
> Good idea.

Done.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] hci_usb: implement suspend/resume
    • From: Johannes Berg <[email protected]>
  • Re: [PATCH] hci_usb: implement suspend/resume
    • From: Oliver Neukum <[email protected]>
  • Re: [PATCH] hci_usb: implement suspend/resume
    • From: Johannes Berg <[email protected]>
  • Re: [PATCH] hci_usb: implement suspend/resume
    • From: Oliver Neukum <[email protected]>

• Prev by Date: [PATCH] arm26: select BLK_DEV_FD only on A5K
• Next by Date: Re: [patch] kbuild: add automatic updateconfig target
• Previous by thread: Re: [PATCH] hci_usb: implement suspend/resume
• Next by thread: [PATCH] ext3: Extends blocksize up to pagesize
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]