Re: [RFC] Moving snd-bt87x and btaudio to drivers/media

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Takashi Iwai wrote:
At Wed, 18 Jan 2006 11:29:28 -0200,
Mauro Carvalho Chehab wrote:
Lee/Andrew/Linus/Takashi and others,

	Currently, we have some audio modules for multimedia devices under
drivers/media and others under sound. They also appear under different
points at Kconfig menus.
	So, for BTTV support, current structure at linus -git is (from Kconfig
perspective):

	Sound/ALSA/PCI Devices/Bt87x Audio capture
		sound/snd-bt87x.ko - ALSA audio for bttv boards
	Sound/OSS/TV Card (bt848) mixer support
		drivers/media/video/tvmixer.ko

	Multimedia/V4L/BT848 V4L
		drivers/media/video/bttv.ko
	Multimedia/V4L/BT848 V4L/DVB-ATSC support
		drivers/media/dvb/bt8xx/bt878.ko
		drivers/media/dvb/bt8xx/dvb-bt8xx.o

	This I couldn't found at any Kconfig (but module exists, and also an
entry at Makefile):
sound/oss/Makefile:obj-$(CONFIG_SOUND_BT878)    += btaudio.o

	For SAA7134 and CX88, all are under Multimedia/V4L. All
OSS/ALSA/DVB/MPEG options are under the driver name.

	IMHO, from users perspective, it makes much more sense if all BTTV
moules (even sound ones) being under bttv video driver. Current module
allows using audio driver without video, but this doesn't make sense,
since audio will be only available, in practice, after selecting a
video/audio input or tuning a channel. These functionalities are
provided by bttv. So, we could even disable audio modules if bttv were
not compiled.

	Also, bug 5995 showed a problem when user have a bttv card and dvb is
also probed. dvb also handles audio, so, currently, it is mutually
exclusive with snd-bt87x audio.

	So, my proposal is to move sound/snd-bt87x.ko to drivers/media, moving
also its menu, and moving tvmixer menu also. After it, should move some
related code at bttv dvb modules, to reduce or eliminate mutually
exclusiveness between the two.
	We might keep supporting btaudio, but I think this is already obsoleted
by alsa one, so, IMHO, we can just drop it. We intend to do the same
with saa7134-oss after some time (kernel 2.6.15 is the first with this
module, so we may remove it on 2.6.18 to give some time for testing).

Which directory do you suppose exactly?  drivers/media/tv (or
something like that), or existing one like drivers/media/video?

Since we have the majority of existing bttv code in drivers/media/video, i was planning to move some existing dvb code into drivers/media/video. If we have alsa code also in the same place, we can have a consolidation of code, might be easier to go through the code, but that is my personal opinion, but having code related to one chip in one place might make it look better probably..


Manu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux