Re: [uml-devel] Re: [PATCH 1/9] uml: avoid sysfs warning on hot-unplug

[Greg KH <greg@kroah.com>]

On Wed, Jan 18, 2006 at 12:53:54PM +0100, Blaisorblade wrote:
> On Wednesday 18 January 2006 02:12, Greg KH wrote:
> > > From: Jeff Dike <jdike@addtoit.com>, Paolo 'Blaisorblade' Giarrusso
> > > <blaisorblade@yahoo.it>
> > >
> > > Define a release method for the ubd and network driver so that sysfs
> > > doesn't complain when one is removed via:
> 
> > What?  No.  The kernel is complaining for a reason, don't try to
> > out-smart it.
> 
> I'm not trying to ignore the warning.

By providing a release function that does nothing, all you are doing is
shutting the kernel up.  You are not doing anything to "fix" the real
problem at all.

> > > host $ uml_mconsole <umid> remove <dev>
> 
> > > Done by Jeff around January for ubd only, later lost, then restored in
> > > his tree - however I'm merging it now since there's no reason to leave
> > > this here.
> 
> > > We don't need to do any cleanup in the new added method, because when
> > > hot-unplug is done by uml_mconsole we already handle cleanup in mconsole
> > > infrastructure, i.e.  mc_device->remove (net_remove/ubd_remove), which is
> > > also the calling method.
> 
> > Huh?  You have 2 different release functions for the same object?
> 
> Not sure which ones you refer. net_remove and ubd_remove are for different 
> devices; mc_device->remove and the sysfs release are in different layers and 
> for different things.

Ok, but you are still adding 2 empty release functions.

Please do not do that, if you think you need this, your code logic is
wrong.

As for your specific bug report, sorry, I really don't know.

good luck,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/