Re: [PATCH] synclink_gt fix size of register value storage

["Jiri Slaby" <xslaby@fi.muni.cz>]

Paul Fulghum wrote:
> Fix incorrect variable size used to hold
> register value. This bug might wipe out a portion of the
> TCR value when setting the interface options.
> 
> Signed-off-by: Paul Fulghum <paulkf@microgate.com>
> 
> 
> --- linux-2.6.16-rc1/drivers/char/synclink_gt.c	2006-01-17 09:31:20.000000000 -0600
> +++ linux-2.6.16-rc1-mg/drivers/char/synclink_gt.c	2006-01-17 10:22:48.000000000 -0600
> @@ -2630,7 +2630,7 @@ static int get_interface(struct slgt_inf
>  static int set_interface(struct slgt_info *info, int if_mode)
>  {
>   	unsigned long flags;
> -	unsigned char val;
> +	unsigned short val;
Shouldn't be this u16 rather than ushort?

regards,
-- 
Jiri Slaby         www.fi.muni.cz/~xslaby
\_.-^-._   jirislaby@gmail.com   _.-^-._/
B67499670407CE62ACC8 22A032CC55C339D47A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/