Re: [PATCH] pepoll_wait ...

Davide Libenzi wrote:
> The attached patch implements the pepoll_wait system call, that extend
> the event wait mechanism with the same logic ppoll and pselect do. The
> definition of pepoll_wait is: [...]

I definitely ACK this patch, it's needed for the same reasons we need
pselect and ppoll.


> +	if (error == -EINTR) {
> +		if (sigmask) {
> +			memcpy(&current->saved_sigmask, &sigsaved, sizeof(sigsaved));
> +			set_thread_flag(TIF_RESTORE_SIGMASK);
> +		}
> +	} else if (sigmask)
> +		sigprocmask(SIG_SETMASK, &sigsaved, NULL);

This part I'd clean up a bit, though.  Move the if (sigmask) test to the
top and have the EINTR test decide what to do.  As is the code would be
a bit irritating if it wouldn't be so trivial.  The important thing is
that you only do something special if sigmask != NULL.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

Attachment: signature.asc
Description: OpenPGP digital signature

---

• Follow-Ups:
  • Re: [PATCH] pepoll_wait ...
    • From: Davide Libenzi <[email protected]>
  • Re: [PATCH] pepoll_wait ...
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH] pepoll_wait ...
    • From: Davide Libenzi <[email protected]>

• Prev by Date: Re: udev/hotplug and automatic /dev node creation
• Next by Date: userspace filesystem Vs kernelspace filesystem
• Previous by thread: [PATCH] pepoll_wait ...
• Next by thread: Re: [PATCH] pepoll_wait ...
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]