[2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



D Binderman <[email protected]> reported the following in kernel 
Bugzilla #5903 [1]:


<--  snip  -->

I just tried to compile kernel 2.6.15.1 with the Intel C compiler. 

It said

sound/pci/cs46xx/dsp_spos_scb_lib.c(673): warning #187: use of "=" where 
"==" may have been intended

The source code is

           snd_assert (rate = 48000);

I agree with the compiler. Suggest new code

           snd_assert (rate == 48000);

<--  snip  -->


Thankfully this bug would only become visible if the assertion was 
false, but anyways it's a bug.

[1] http://bugzilla.kernel.org/show_bug.cgi?id=5903


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.15-mm4-full/sound/pci/cs46xx/dsp_spos_scb_lib.c.old	2006-01-16 20:20:23.000000000 +0100
+++ linux-2.6.15-mm4-full/sound/pci/cs46xx/dsp_spos_scb_lib.c	2006-01-16 20:21:17.000000000 +0100
@@ -677,7 +677,7 @@
 		if (pass_through) {
 			/* wont work with any other rate than
 			   the native DSP rate */
-			snd_assert (rate = 48000);
+			snd_assert (rate == 48000);
 
 			scb = cs46xx_dsp_create_generic_scb(chip,scb_name,(u32 *)&src_task_scb,
 							    dest,"DMAREADER",parent_scb,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux