In-Reply-To: <[email protected]>
On Thu, 12 Jan 2006, Adrian Bunk wrote:
> On Wed, Jan 11, 2006 at 09:31:32AM -0500, Dmitry Torokhov wrote:
> > On 1/11/06, Patrick Read <[email protected]> wrote:
> > > On 1/9/06, Dmitry Torokhov <[email protected]> wrote:
> > > > ===================================================================
> > > > --- work.orig/drivers/usb/input/pid.c
> > > > +++ work/drivers/usb/input/pid.c
> > > > @@ -259,7 +259,7 @@ static int hid_pid_upload_effect(struct
> > > > int hid_pid_init(struct hid_device *hid)
> > > > {
> > > > struct hid_ff_pid *private;
> > > > - struct hid_input *hidinput = list_entry(&hid->inputs, struct hid_input, list);
> > > > + struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
> > > > struct input_dev *input_dev = hidinput->input;
> > > >
> > > > private = hid->ff_private = kzalloc(sizeof(struct hid_ff_pid), GFP_KERNEL);
> > > >
> > >
> > > The above fix works like a charm. 2.6.15 is running on this very
> > > computer that I'm typing on.
> > >
> > > Thank you for your good work. Please ensure that this fix gets
> > > incorporated in the mainline kernel.
> > >
> >
> > Thank you for testing it, I will forward it to Linus.
>
> Could you also forward it [email protected] for inclusion in 2.6.15.x?
I don't see it in Linus's tree yet.
Could it still be put into 2.6.15.1?
--
From: Dmitry Torokhov <[email protected]>
Fix oops in usbhid.
--- work.orig/drivers/usb/input/pid.c
+++ work/drivers/usb/input/pid.c
@@ -259,7 +259,7 @@ static int hid_pid_upload_effect(struct
int hid_pid_init(struct hid_device *hid)
{
struct hid_ff_pid *private;
- struct hid_input *hidinput = list_entry(&hid->inputs, struct hid_input, list);
+ struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
struct input_dev *input_dev = hidinput->input;
private = hid->ff_private = kzalloc(sizeof(struct hid_ff_pid), GFP_KERNEL);
--
Chuck
Currently reading: _Olympos_ by Dan Simmons
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
