Re: [PATCH 1/3] msi vector targeting abstractions

Grant Grundler writes:

> > +	if ((status = msi_arch_init()) < 0) {
> 
> Willy told me I should always complain about assignment in if() statements :)

We are getting incredibly politically correct these days, aren't we.

I see nothing wrong with that if statement.  It's perfectly valid,
idiomatic C.  You can ignore Willy if you like. :)

(I would look askance at something that did an assignment as one of
the parameters of a procedure call in an if statement, though.)

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/3] msi vector targeting abstractions
    • From: Grant Grundler <[email protected]>

• References:
  • [PATCH 0/3] msi abstractions and support for altix
    • From: Mark Maule <[email protected]>
  • [PATCH 1/3] msi vector targeting abstractions
    • From: Mark Maule <[email protected]>
  • Re: [PATCH 1/3] msi vector targeting abstractions
    • From: Grant Grundler <[email protected]>

• Prev by Date: Why check_media_change & revalidate if interrupt is there
• Next by Date: Re: [Lse-tech] Re: [ckrm-tech] Re: [PATCH 00/01] Move Exit Connectors
• Previous by thread: Re: [PATCH 1/3] msi vector targeting abstractions
• Next by thread: Re: [PATCH 1/3] msi vector targeting abstractions
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]