Re: 2.6.15-git7 oopses in ext3 during LTP runs

>the conversion is buggy.
>
>mutex_trylock has the same convention as spin_try_lock (which is the
>opposite of down_trylock). THe conversion forgot to add a !
>
> static void ext3_write_super (struct super_block * sb)
> {
>-	if (mutex_trylock(&sb->s_lock) != 0)
>+	if (!mutex_trylock(&sb->s_lock) != 0)

How about a nicer...?

        if(mutex_trylock(&sb->s_lock) == 0)



Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • 2.6.15-git7 oopses in ext3 during LTP runs
    • From: Andi Kleen <[email protected]>
  • Re: 2.6.15-git7 oopses in ext3 during LTP runs
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.15-git7 oopses in ext3 during LTP runs
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: 2.6.15-mm3
• Next by Date: linker error in 2.6.15-git: drivers/media/video/tuner.o:(.bss+0x0): multiple definition of `debug'
• Previous by thread: Re: 2.6.15-git7 oopses in ext3 during LTP runs II - more problems
• Next by thread: 2.6.15-rt4-sr1
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]