On Wed, Jan 11, 2006 at 09:32:17AM -0400, Anderson Briglia wrote:
> Pierre Ossman wrote:
> > Anderson Briglia wrote:
> >
> >
> >>@@ -238,6 +295,11 @@ int mmc_register_card(struct mmc_card *c
> >> if (ret)
> >> device_del(&card->dev);
> >> }
> >>+#ifdef CONFIG_MMC_PASSWORDS
> >>+ ret = device_create_file(&card->dev, &mmc_dev_attr_lockable);
> >>+ if (ret)
> >>+ device_del(&card->dev);
> >>+#endif
> >> }
> >> return ret;
> >>}
> >>
> >>
> >
> >
> > It might be wise to also check the command classes here. I don't believe
> > SDIO supports locking.
>
> In this case, the lockable attribute will show "unlockable", which is
> the expected behavior. The lockable attribute will always be present,
> the card being lockable or not.
"unlockable" seems to be confusing.
"Unlockable" may mean something which is locked but can be unlocked
(unlock-able). Or it may mean something which can't be locked
(un-lockable).
Maybe returning "unsupported", "locked", "unlocked" etc would be
clearer?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
