[PATCH] netlink oops fix due to incorrect error code

Fixed oops after failed netlink socket creation.
Wrong parathenses in if() statement caused err to be 1,
instead of negative value.
Trivial fix, not trivial to find though.

Signed-Off-By: Dmitry Mishin <[email protected]>
Signed-Off-By: Kirill Korotaev <[email protected]>

Kirill
P.S. against 2.6.15

--- ./net/netlink/af_netlink.c.nlfix	2006-01-06 18:37:28.000000000 +0300
+++ ./net/netlink/af_netlink.c	2006-01-09 16:40:49.000000000 +0300
@@ -416,7 +416,7 @@ static int netlink_create(struct socket 
 	groups = nl_table[protocol].groups;
 	netlink_unlock_table();
 
-	if ((err = __netlink_create(sock, protocol) < 0))
+	if ((err = __netlink_create(sock, protocol)) < 0)
 		goto out_module;
 
 	nlk = nlk_sk(sock->sk);

---

• Follow-Ups:
  • Re: [stable] [PATCH] netlink oops fix due to incorrect error code
    • From: Chris Wright <[email protected]>
  • Re: [PATCH] netlink oops fix due to incorrect error code
    • From: Patrick McHardy <[email protected]>
  • [PATCH] Fix more "if ((err = foo() < 0))" typos
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: Why the DOS has many ntfs read and write driver,but the linux can't for a long time
• Next by Date: Re: [2.6.15] running tcpdump on 3c905b causes freeze (reproducable)
• Previous by thread: [PATCH] i386/x86-64: Removes 'enable_timer_pin_1' command-line option.
• Next by thread: [PATCH] Fix more "if ((err = foo() < 0))" typos
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]