Re: [PATCH] wistron_btns: Fix missing BIOS signature handling

On Sunday 08 January 2006 01:39, Miloslav Trmac wrote:
> offset can never be < 0 because it has type size_t.  The driver
> currently oopses on insmod if BIOS does not support the interface,
> instead of refusing to load.
> 

I don't really like that casting, should we just change offset to ssize_t?

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] wistron_btns: Fix missing BIOS signature handling, take 2
    • From: Miloslav Trmac <[email protected]>

• References:
  • [PATCH] wistron_btns: Fix missing BIOS signature handling
    • From: Miloslav Trmac <[email protected]>

• Prev by Date: [PATCH] wistron_btns: Fix missing BIOS signature handling
• Next by Date: Re: Why is 2.4.32 four times faster than 2.6.14.6??
• Previous by thread: [PATCH] wistron_btns: Fix missing BIOS signature handling
• Next by thread: [PATCH] wistron_btns: Fix missing BIOS signature handling, take 2
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]