Re: [Linux-fbdev-devel] drivers/video/imsttfb.c: setclkMHz: clk_p is always 0

• To: [email protected]
• Subject: Re: [Linux-fbdev-devel] drivers/video/imsttfb.c: setclkMHz: clk_p is always 0
• From: "Antonino A. Daplas" <[email protected]>
• Date: Sat, 07 Jan 2006 09:34:25 +0800
• Cc: [email protected], [email protected]
• Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=LPWdbLjjqqdlhfzPJ437LU5kQKwfnVIRNvC1IDhchURkRGK/OAeMdB0RUHwef3bY1eyp+CM+SYuBkP6xpVuDsazRnFJWebZaYrrYx8kmyb1teEp44AJtCM5k+nu40iRL625X3LWY3CTxuKrmTc+v1jSWF4U7Wl8eJzLqToKMCQ0=
• In-reply-to: <[email protected]>
• References: <[email protected]>
• Sender: [email protected]
• User-agent: Thunderbird 1.5 (X11/20051201)

Adrian Bunk wrote:
> The Coverity checker noticed that in the function setclkMHz in 
> drivers/video/imsttfb.c, the variable clk_p is never assigned a value 
> other than 0.
> 
> Could someone understanding this code decide whether this is a real bug 
> or whether clk_p can be replaced by 0?
> 

It does look like to be an oversight.  The same is present in Xorg code
too.

Tony

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • drivers/video/imsttfb.c: setclkMHz: clk_p is always 0
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [PATCH] non-linear frame buffer read/write access
• Next by Date: [PATCH] Drop vmlinux dependency from "make install"
• Previous by thread: drivers/video/imsttfb.c: setclkMHz: clk_p is always 0
• Next by thread: drivers/acpi/scan.c: inconsequent NULL handling
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]