Re: [PATCH] x86_64 io_apic: memorize at bootup where the i8259 is

[Yinghai Lu <yinghai.lu@amd.com>]

On 1/6/06, Eric W. Biederman <ebiederm@xmission.com> wrote:
>
>@@ -1249,12 +1313,14 @@ void disable_IO_APIC(void)
>                * Add it to the IO-APIC irq-routing table:
>                */
>               spin_lock_irqsave(&ioapic_lock, flags);
>-               io_apic_write(0, 0x11+2*pin, *(((int *)&entry)+1));
>-               io_apic_write(0, 0x10+2*pin, *(((int *)&entry)+0));
>+               io_apic_write(ioapic_i8259.apic, 0x11+2*ioapic_i8259.pin,
>+                       *(((int *)&entry)+1));
>+               io_apic_write(ioapic_i8259.apic, 0x10+2*ioapic_i8259.pin,
>+                       *(((int *)&entry)+1));
>               spin_unlock_irqrestore(&ioapic_lock, flags);
>       }
>
>-       disconnect_bsp_APIC(pin != -1);
>+       disconnect_bsp_APIC(ioapci_i8259.pin != -1);
> }

There is a typo

+               io_apic_write(ioapic_i8259.apic, 0x10+2*ioapic_i8259.pin,
+                       *(((int *)&entry)+1));

===>

+               io_apic_write(ioapic_i8259.apic, 0x10+2*ioapic_i8259.pin,
+                       *(((int *)&entry)+0));

YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/