Re: [patch 2/4] fix input layer f_ops abuse

On 1/6/06, Arjan van de Ven <[email protected]> wrote:
> From: Arjan van de Ven <[email protected]>
>
> The input layer has an assignment to a live ->fops, just after creating the
> fops as a duplicate of another one. Just move this assignment a few lines up to avoid
> the race and the assignment to a live fops
>

I do not understand how it will fix the "race", there is still a split
second between "entry" having default fops and modified one. I'd
prefer you fix the comment to reflect that the only change is because
fops is now constant.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 0/4] Series to allow a "const" file_operations struct
    • From: Arjan van de Ven <[email protected]>
  • [patch 2/4] fix input layer f_ops abuse
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: [PATCH] bio: gcc warning fix.
• Next by Date: Re: [PATCH] lib: Fix bug in int_sqrt() for 64 bit longs
• Previous by thread: [patch 2/4] fix input layer f_ops abuse
• Next by thread: [patch 4/4] Actually make the f_ops field const
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]