Re: [2.6 patch] drivers/scsi/qla2xxx/Kconfig: two fixes

[Adrian Bunk <bunk@stusta.de>]

On Fri, Jan 06, 2006 at 01:12:41PM -0800, Andrew Vasquez wrote:
> On Fri, 06 Jan 2006, Adrian Bunk wrote:
> 
> > This patch contains the following fixes for 
> > drivers/scsi/qla2xxx/Kconfig:
> > - add a help text for SCSI_QLA2XXX_EMBEDDED_FIRMWARE
> > - the firmware modules must depend on SCSI_QLA2XXX to prevent
> >   illegal configurations like SCSI_QLA2XXX=m, SCSI_QLA21XX=y
> > 
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> Ack.

There's another bug that must be fixed:

SCSI_QLA2XXX must be renamed.

The problem is that up to 2.6.15, it was a not user visible variable 
that was set for _everyone_ with SCSI && PCI and that didn't have any 
influence on what was built.

E.g. it is set in the .config for my computer since my computer has PCI 
cards and I'm using USB mass storage.

Due to the change of SCSI_QLA2XXX to a user-visible option that builds 
the driver, this means that suddenly after upgrading the kernel and 
running "make oldconfig" a SCSI driver gets built the user never 
selected.

Do you have any suggestions for a new name?
We could e.g. name it SCSI_QLAXXXX since the driver also supports 
6312/6322, or name it simply SCSI_QLA.

> Andrew Vasquez

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/